cleanup: Minimize deep_unpack() usage
deep_unpack()[1] will unpack a variant and its children, but only up to one level. lookup_value()[2] will directly search for a value with a linear scan. Performing a deep_unpack() + lookup can be a more expensive operation when we are looking for just a single value compared to just perform the lookup_value() directly in C. Avoid the deep_unpack() usage when we perform a single check presence. [1] https://gjs.guide/guides/glib/gvariant.html#deepunpack [2] https://docs.gtk.org/glib/method.Variant.lookup_value.html Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2416>
This commit is contained in:
parent
23bfd08b3c
commit
ade4b23796
@ -28,7 +28,8 @@ var Manager = class extends Signals.EventEmitter {
|
||||
|
||||
this._aggregateProvider.connectObject('g-properties-changed',
|
||||
(proxy, properties) => {
|
||||
if ('Realms' in properties.deep_unpack())
|
||||
const realmsChanged = !!properties.lookup_value('Realms', null);
|
||||
if (realmsChanged)
|
||||
this._reloadRealms();
|
||||
}, this);
|
||||
}
|
||||
@ -67,7 +68,8 @@ var Manager = class extends Signals.EventEmitter {
|
||||
this._reloadRealm(realm);
|
||||
|
||||
realm.connect('g-properties-changed', (proxy, properties) => {
|
||||
if ('Configured' in properties.deep_unpack())
|
||||
const configuredChanged = !!properties.lookup_value('Configured', null);
|
||||
if (configuredChanged)
|
||||
this._reloadRealm(realm);
|
||||
});
|
||||
}
|
||||
|
@ -243,7 +243,8 @@ var BroadbandModem = GObject.registerClass({
|
||||
this._proxy_cdma = new BroadbandModemCdmaProxy(Gio.DBus.system, 'org.freedesktop.ModemManager1', path);
|
||||
|
||||
this._proxy.connect('g-properties-changed', (proxy, properties) => {
|
||||
if ('SignalQuality' in properties.deep_unpack())
|
||||
const signalQualityChanged = !!properties.lookup_value('SignalQuality', null);
|
||||
if (signalQualityChanged)
|
||||
this._reloadSignalQuality();
|
||||
});
|
||||
this._reloadSignalQuality();
|
||||
|
@ -73,7 +73,8 @@ var SmartcardManager = class extends Signals.EventEmitter {
|
||||
this._updateToken(token);
|
||||
|
||||
token.connect('g-properties-changed', (proxy, properties) => {
|
||||
if ('IsInserted' in properties.deep_unpack()) {
|
||||
const isInsertedChanged = !!properties.lookup_value('IsInserted', null);
|
||||
if (isInsertedChanged) {
|
||||
this._updateToken(token);
|
||||
|
||||
if (token.IsInserted)
|
||||
|
@ -181,8 +181,8 @@ var GeoclueAgent = GObject.registerClass({
|
||||
}
|
||||
|
||||
_onGeocluePropsChanged(proxy, properties) {
|
||||
let unpacked = properties.deep_unpack();
|
||||
if ("InUse" in unpacked)
|
||||
const inUseChanged = !!properties.lookup_value('InUse', null);
|
||||
if (inUseChanged)
|
||||
this.notify('in-use');
|
||||
}
|
||||
|
||||
|
@ -49,7 +49,8 @@ class Indicator extends SystemIndicator {
|
||||
g_interface_info: colorInfo,
|
||||
});
|
||||
this._proxy.connect('g-properties-changed', (p, properties) => {
|
||||
if ('NightLightActive' in properties.deep_unpack())
|
||||
const nightLightActiveChanged = !!properties.lookup_value('NightLightActive', null);
|
||||
if (nightLightActiveChanged)
|
||||
this._sync();
|
||||
});
|
||||
this._proxy.init_async(GLib.PRIORITY_DEFAULT, null)
|
||||
|
@ -52,10 +52,9 @@ class PowerProfilesToggle extends QuickMenuToggle {
|
||||
if (error) {
|
||||
log(error.message);
|
||||
} else {
|
||||
this._proxy.connect('g-properties-changed',
|
||||
(p, properties) => {
|
||||
const propertyNames = properties.deep_unpack();
|
||||
if ('Profiles' in propertyNames)
|
||||
this._proxy.connect('g-properties-changed', (p, properties) => {
|
||||
const profilesChanged = !!properties.lookup_value('Profiles', null);
|
||||
if (profilesChanged)
|
||||
this._syncProfiles();
|
||||
this._sync();
|
||||
});
|
||||
|
@ -83,13 +83,12 @@ var Client = class extends Signals.EventEmitter {
|
||||
}
|
||||
|
||||
_onPropertiesChanged(proxy, properties) {
|
||||
let unpacked = properties.deep_unpack();
|
||||
if (!('Probing' in unpacked))
|
||||
return;
|
||||
|
||||
const probingChanged = !!properties.lookup_value('Probing', null);
|
||||
if (probingChanged) {
|
||||
this.probing = this._proxy.Probing;
|
||||
this.emit('probing-changed', this.probing);
|
||||
}
|
||||
}
|
||||
|
||||
_onDeviceAdded(proxy, emitter, params) {
|
||||
let [path] = params;
|
||||
|
Loading…
Reference in New Issue
Block a user