cleanup: Minimize deep_unpack() usage
deep_unpack()[1] will unpack a variant and its children, but only up to one level. lookup_value()[2] will directly search for a value with a linear scan. Performing a deep_unpack() + lookup can be a more expensive operation when we are looking for just a single value compared to just perform the lookup_value() directly in C. Avoid the deep_unpack() usage when we perform a single check presence. [1] https://gjs.guide/guides/glib/gvariant.html#deepunpack [2] https://docs.gtk.org/glib/method.Variant.lookup_value.html Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2416>
This commit is contained in:

committed by
Marge Bot

parent
23bfd08b3c
commit
ade4b23796
@ -73,7 +73,8 @@ var SmartcardManager = class extends Signals.EventEmitter {
|
||||
this._updateToken(token);
|
||||
|
||||
token.connect('g-properties-changed', (proxy, properties) => {
|
||||
if ('IsInserted' in properties.deep_unpack()) {
|
||||
const isInsertedChanged = !!properties.lookup_value('IsInserted', null);
|
||||
if (isInsertedChanged) {
|
||||
this._updateToken(token);
|
||||
|
||||
if (token.IsInserted)
|
||||
|
Reference in New Issue
Block a user