brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

messageList: Only apply special styling to symbolic icons

Browse Source 
The styling introduced in commit 8fed0b83d was only intended
for symbolics, it looks weird when applied to full-color icons.

So instead of using the GIcon type, apply the special styling
based on the new StIcon:is-symbolic property.

Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/7620
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3296>
This commit is contained in:
Florian Müllner 2024-05-02 19:53:04 +02:00 committed by Marge Bot
parent 56cc755bf6
commit a94b80b2d4
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
js/ui/messageList.js
View File

@ -478,6 +478,13 @@ export const Message = GObject.registerClass({
}); });
hbox.add_child(this._icon); hbox.add_child(this._icon);
this._icon.connect('notify::is-symbolic', () => {
if (this._icon.is_symbolic)
this._icon.add_style_class_name('message-themed-icon');
else
this._icon.remove_style_class_name('message-themed-icon');
});
const contentBox = new St.BoxLayout({ const contentBox = new St.BoxLayout({
style_class: 'message-content', style_class: 'message-content',
vertical: true, vertical: true,
@ -534,11 +541,6 @@ export const Message = GObject.registerClass({
set icon(icon) { set icon(icon) {
this._icon.gicon = icon; this._icon.gicon = icon;
if (icon instanceof Gio.ThemedIcon)
this._icon.add_style_class_name('message-themed-icon');
else
this._icon.remove_style_class_name('message-themed-icon');
this._icon.visible = !!icon; this._icon.visible = !!icon;
this.notify('icon'); this.notify('icon');
} }