Adopt EventEmitter class instead of injecting Signal methods
Introduce a new class, EventEmitter, which implements signal handling for pure JavaScript classes. EventEmitter still utilizes GJS' addSignalMethods internally. EventEmitter allows static typechecking to understand the structure of event-emitting JS classes and makes creating child classes simpler. The name 'EventEmitter' mirrors a common name for this pattern in Node and in JS libraries. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2043>
This commit is contained in:
@ -20,15 +20,18 @@
|
||||
* Contributor:
|
||||
* Magdalen Berns <m.berns@sms.ed.ac.uk>
|
||||
*/
|
||||
/* exported FocusCaretTracker */
|
||||
|
||||
const Atspi = imports.gi.Atspi;
|
||||
const Signals = imports.signals;
|
||||
const Signals = imports.misc.signals;
|
||||
|
||||
const CARETMOVED = 'object:text-caret-moved';
|
||||
const STATECHANGED = 'object:state-changed';
|
||||
|
||||
var FocusCaretTracker = class FocusCaretTracker {
|
||||
var FocusCaretTracker = class FocusCaretTracker extends Signals.EventEmitter {
|
||||
constructor() {
|
||||
super();
|
||||
|
||||
this._atspiListener = Atspi.EventListener.new(this._onChanged.bind(this));
|
||||
|
||||
this._atspiInited = false;
|
||||
@ -86,4 +89,3 @@ var FocusCaretTracker = class FocusCaretTracker {
|
||||
this._caretListenerRegistered = false;
|
||||
}
|
||||
};
|
||||
Signals.addSignalMethods(FocusCaretTracker.prototype);
|
||||
|
Reference in New Issue
Block a user