brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Adopt EventEmitter class instead of injecting Signal methods

Browse Source 
Introduce a new class, EventEmitter, which implements signal
handling for pure JavaScript classes. EventEmitter still
utilizes GJS' addSignalMethods internally.

EventEmitter allows static typechecking to understand the
structure of event-emitting JS classes and makes creating
child classes simpler.

The name 'EventEmitter' mirrors a common name for this pattern
in Node and in JS libraries.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2043>
This commit is contained in:
Evan Welsh
2022-07-04 18:30:44 -04:00
parent 9e30afe678
commit a88e59c1a8
39 changed files with 204 additions and 169 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
js/misc/smartcardManager.js
View File

@ -2,7 +2,7 @@
/* exported getSmartcardManager */
const Gio = imports.gi.Gio;
const Signals = imports.signals;
const Signals = imports.misc.signals;
const ObjectManager = imports.misc.objectManager;
@ -25,8 +25,10 @@ function getSmartcardManager() {
return _smartcardManager;
}
var SmartcardManager = class {
var SmartcardManager = class extends Signals.EventEmitter {
constructor() {
super();
this._objectManager = new ObjectManager.ObjectManager({
connection: Gio.DBus.session,
name: 'org.gnome.SettingsDaemon.Smartcard',
@ -114,4 +116,3 @@ var SmartcardManager = class {
return true;
}
};
Signals.addSignalMethods(SmartcardManager.prototype);