From a870a4d6de093e469d50dcbba81c4636f053c481 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Tue, 7 Feb 2017 20:22:18 +0100 Subject: [PATCH] widget: Only include visible actors in focus chain It isn't useful to move the keyboard focus to a hidden actor, so only include visible actors in the focus chain - this is in fact the documented behavior of st_widget_get_focus_chain(), so having the default implementation return all children has always been unexpected. https://bugzilla.gnome.org/show_bug.cgi?id=778158 --- src/st/st-widget.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/src/st/st-widget.c b/src/st/st-widget.c index e20c845a0..002249d25 100644 --- a/src/st/st-widget.c +++ b/src/st/st-widget.c @@ -821,7 +821,19 @@ st_widget_get_paint_volume (ClutterActor *self, static GList * st_widget_real_get_focus_chain (StWidget *widget) { - return clutter_actor_get_children (CLUTTER_ACTOR (widget)); + GList *children, *l, *visible = NULL; + + children = clutter_actor_get_children (CLUTTER_ACTOR (widget)); + + for (l = children; l; l = l->next) + { + if (clutter_actor_is_visible (CLUTTER_ACTOR (l->data))) + visible = g_list_prepend (visible, l->data); + } + + g_list_free (children); + + return g_list_reverse (visible); }