brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

js: Cleanup use of StBin

Browse Source 
StBins (inc StButton) should have their content managed via :child
rather than add_child()

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3010>
This commit is contained in:
Zander Brown
2023-11-08 10:20:03 +00:00
committed by Marge Bot
parent 49cca32ca5
commit a830edf8cf
7 changed files with 29 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
js/ui/search.js
View File

@ -304,7 +304,7 @@ class ListSearchResults extends SearchResultsBase {
});
this._container.add_child(this._content);
this._resultDisplayBin.set_child(this._container);
this._resultDisplayBin.child = this._container;
}
_setMoreCount(count) {
@ -468,10 +468,10 @@ class GridSearchResults extends SearchResultsBase {
this._grid.layout_manager.spacing = node.get_length('spacing');
});
this._resultDisplayBin.set_child(new St.Bin({
this._resultDisplayBin.child = new St.Bin({
child: this._grid,
x_align: Clutter.ActorAlign.CENTER,
}));
});
this._maxResults = provider.maxResults ?? -1;
}
@ -588,9 +588,11 @@ export const SearchResultsView = GObject.registerClass({
x_align: Clutter.ActorAlign.CENTER,
y_align: Clutter.ActorAlign.CENTER,
});
this._statusBin = new St.Bin({y_expand: true});
this._statusBin = new St.Bin({
y_expand: true,
child: this._statusText,
});
this.add_child(this._statusBin);
this._statusBin.add_child(this._statusText);
this._highlightDefault = false;
this._defaultResult = null;