From a5cf08ac556dc9c339c03bb8d7fb24e5c6b56d38 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Luk=C3=A1=C5=A1=20Tyrychtr?= Date: Thu, 11 May 2023 11:19:36 +0200 Subject: [PATCH] a11y: Don't create a parent loop for quick settings sliders Rather than returning the parent container of the slider, which presents itself as the slider, return the parent of the slider container. https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/6686 Part-of: --- js/ui/quickSettings.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/js/ui/quickSettings.js b/js/ui/quickSettings.js index 7f08d6f75..9016fedf6 100644 --- a/js/ui/quickSettings.js +++ b/js/ui/quickSettings.js @@ -323,7 +323,10 @@ var QuickSlider = GObject.registerClass({ }); box.add_child(sliderBin); - sliderBin.set_accessible(this.slider.get_accessible()); + // Make the slider bin transparent for a11y + const sliderAccessible = this.slider.get_accessible(); + sliderAccessible.set_parent(sliderBin.get_parent().get_accessible()); + sliderBin.set_accessible(sliderAccessible); sliderBin.connect('event', (bin, event) => this.slider.event(event, false)); this._menuButton = new St.Button({