diff --git a/js/ui/locatePointer.js b/js/ui/locatePointer.js index 10caa656d..6ae29419a 100644 --- a/js/ui/locatePointer.js +++ b/js/ui/locatePointer.js @@ -11,12 +11,26 @@ const LOCATE_POINTER_SCHEMA = "org.gnome.desktop.interface"; var LocatePointer = class { constructor() { this._settings = new Gio.Settings({ schema_id: LOCATE_POINTER_SCHEMA }); - this._ripples = new Ripples.Ripples(0.5, 0.5, 'ripple-pointer-location'); - this._ripples.addTo(Main.uiGroup); + this._settings.connect(`changed::${LOCATE_POINTER_KEY}`, () => this._syncEnabled()); + this._syncEnabled(); + } + + _syncEnabled() { + let enabled = this._settings.get_boolean(LOCATE_POINTER_KEY); + if (enabled == !!this._ripples) + return; + + if (enabled) { + this._ripples = new Ripples.Ripples(0.5, 0.5, 'ripple-pointer-location'); + this._ripples.addTo(Main.uiGroup); + } else { + this._ripples.destroy(); + this._ripples = null; + } } show() { - if (!this._settings.get_boolean(LOCATE_POINTER_KEY)) + if (!this._ripples) return; let [x, y] = global.get_pointer();