brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

workspacesView: Fix off-by-one error

Browse Source 
The scroll adjustment's upper value corresponds to the number of
workspaces, not to the last workspace index. We want the latter
when mirroring the layout in RTL locales, so subtract 1.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1598>
This commit is contained in:
Florian Müllner 2021-01-08 02:14:42 +01:00
parent 7462347905
commit 9f0e7632a6
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
js/ui/workspacesView.js
View File

@ -300,7 +300,7 @@ class WorkspacesView extends WorkspacesViewBase {
const vertical = workspaceManager.layout_rows === -1; const vertical = workspaceManager.layout_rows === -1;
const rtl = this.text_direction === Clutter.TextDirection.RTL; const rtl = this.text_direction === Clutter.TextDirection.RTL;
const progress = vertical || !rtl const progress = vertical || !rtl
? adj.value : adj.upper - adj.value; ? adj.value : adj.upper - adj.value - 1;
for (const ws of this._workspaces) { for (const ws of this._workspaces) {
if (vertical) if (vertical)