brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

js: Stop using {v,h}scroll properties

Browse Source 
We only use them to access the corresponding adjustments, and
ScrollView now exposes those directly.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3020>
This commit is contained in:
Florian Müllner
2023-11-15 14:31:37 +01:00
committed by Marge Bot
parent a63d5b6b09
commit 998d703bc2
8 changed files with 16 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
js/ui/components/telepathyClient.js
View File

@ -890,8 +890,8 @@ class ChatNotificationBanner extends MessageTray.NotificationBanner {
// Keep track of the bottom position for the current adjustment and
// force a scroll to the bottom if things change while we were at the
// bottom
this._oldMaxScrollValue = this._scrollArea.vscroll.adjustment.value;
this._scrollArea.vscroll.adjustment.connect('changed', adjustment => {
this._oldMaxScrollValue = this._scrollArea.vadjustment.value;
this._scrollArea.vadjustment.connect('changed', adjustment => {
if (adjustment.value === this._oldMaxScrollValue)
this.scrollTo(St.Side.BOTTOM);
this._oldMaxScrollValue = Math.max(adjustment.lower, adjustment.upper - adjustment.page_size);
@ -917,7 +917,7 @@ class ChatNotificationBanner extends MessageTray.NotificationBanner {
}
scrollTo(side) {
let adjustment = this._scrollArea.vscroll.adjustment;
let adjustment = this._scrollArea.vadjustment;
if (side === St.Side.TOP)
adjustment.value = adjustment.lower;
else if (side === St.Side.BOTTOM)