brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

endSessionDialog: Small cleanup

Browse Source 
Array.prototype.push() returns the new number of elements, so
no need to track the number separately.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2369>
This commit is contained in:
Florian Müllner 2022-07-08 21:36:07 +02:00 committed by Marge Bot
parent 9375b485ea
commit 97b2079257
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
js/ui/endSessionDialog.js
View File

@ -647,7 +647,6 @@ class EndSessionDialog extends ModalDialog.ModalDialog {
_loadSessions() { _loadSessions() {
this._loginManager.listSessions(result => { this._loginManager.listSessions(result => {
let n = 0;
for (let i = 0; i < result.length; i++) { for (let i = 0; i < result.length; i++) {
let [id_, uid_, userName, seat_, sessionPath] = result[i]; let [id_, uid_, userName, seat_, sessionPath] = result[i];
let proxy = new LogindSession(Gio.DBus.system, 'org.freedesktop.login1', sessionPath); let proxy = new LogindSession(Gio.DBus.system, 'org.freedesktop.login1', sessionPath);
@ -675,7 +674,7 @@ class EndSessionDialog extends ModalDialog.ModalDialog {
type: proxy.Type, type: proxy.Type,
remote: proxy.Remote, remote: proxy.Remote,
}; };
this._sessions.push(session); const nSessions = this._sessions.push(session);
let userAvatar = new UserWidget.Avatar(session.user, { iconSize: _ITEM_ICON_SIZE }); let userAvatar = new UserWidget.Avatar(session.user, { iconSize: _ITEM_ICON_SIZE });
userAvatar.update(); userAvatar.update();
@ -699,8 +698,7 @@ class EndSessionDialog extends ModalDialog.ModalDialog {
this._sessionSection.list.add_child(listItem); this._sessionSection.list.add_child(listItem);
// limit the number of entries // limit the number of entries
n++; if (nSessions === MAX_USERS_IN_SESSION_DIALOG)
if (n == MAX_USERS_IN_SESSION_DIALOG)
break; break;
} }