brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update hint texts of all entries

Browse Source 
The design team discussed the ellipses at the end of the hint text of
our entries and, even though they are present in most mockups, it turned
out they don't like them, so remove them.

It also turned out they don't like the prefixes like "Enter" before it,
so remove those, too.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/977
This commit is contained in:
Jonas Dreßler 2020-02-14 22:11:27 +01:00 committed by Florian Müllner
parent 775c3345eb
commit 95ebbb9360
4 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
js/gdm/loginDialog.js
View File

@ -914,7 +914,7 @@ var LoginDialog = GObject.registerClass({
_askForUsernameAndBeginVerification() { _askForUsernameAndBeginVerification() {
this._authPrompt.setUser(null); this._authPrompt.setUser(null);
this._authPrompt.setQuestion(_('Username…')); this._authPrompt.setQuestion(_('Username'));
this._showRealmLoginHint(this._realmManager.loginFormat); this._showRealmLoginHint(this._realmManager.loginFormat);

8
js/ui/components/polkitAgent.js
View File

@ -271,12 +271,12 @@ var AuthenticationDialog = GObject.registerClass({
} }
// Hack: The request string comes directly from PAM, if it's "Password:" // Hack: The request string comes directly from PAM, if it's "Password:"
// we replace it with our own, if it's something else we replace the // we replace it with our own to allow localization, if it's something
// last colon and any trailing spaces with a "…". // else we remove the last colon and any trailing or leading spaces.
if (request === 'Password:' || request === 'Password: ') if (request === 'Password:' || request === 'Password: ')
this._passwordEntry.hint_text = _('Enter Password…'); this._passwordEntry.hint_text = _('Password');
else else
this._passwordEntry.hint_text = request.replace(/: *$/, '…'); this._passwordEntry.hint_text = request.replace(/: *$/, '').trim();
this._passwordEntry.password_visible = echoOn; this._passwordEntry.password_visible = echoOn;

2
js/ui/overview.js
View File

@ -104,7 +104,7 @@ class OverviewActor extends St.BoxLayout {
in the search entry when no search is in the search entry when no search is
active; it should not exceed ~30 active; it should not exceed ~30
characters. */ characters. */
hint_text: _("Type to search…"), hint_text: _('Type to search'),
track_hover: true, track_hover: true,
can_focus: true, can_focus: true,
}); });

4
js/ui/shellMountOperation.js
View File

@ -303,7 +303,7 @@ var ShellMountPasswordDialog = GObject.registerClass({
this._pimEntry = new St.PasswordEntry({ this._pimEntry = new St.PasswordEntry({
style_class: 'prompt-dialog-password-entry', style_class: 'prompt-dialog-password-entry',
hint_text: _('Enter PIM Number…'), hint_text: _('PIM Number'),
can_focus: true, can_focus: true,
x_expand: true, x_expand: true,
}); });
@ -323,7 +323,7 @@ var ShellMountPasswordDialog = GObject.registerClass({
this._passwordEntry = new St.PasswordEntry({ this._passwordEntry = new St.PasswordEntry({
style_class: 'prompt-dialog-password-entry', style_class: 'prompt-dialog-password-entry',
hint_text: _('Enter Password…'), hint_text: _('Password'),
can_focus: true, can_focus: true,
x_expand: true, x_expand: true,
}); });