brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

AppDisplay: fix allocation loop warnings

Browse Source 
Don't use a constraint to position the boxpointer horizontally. Instead,
use the right alignment flags and let the layout managers do their job.

https://bugzilla.gnome.org/show_bug.cgi?id=694284
This commit is contained in:
Giovanni Campagna 2013-02-20 17:20:46 +01:00
parent 9f3afdf928
commit 95602eb85d
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
js/ui/appDisplay.js
View File

@ -567,10 +567,6 @@ const FolderIcon = new Lang.Class({
this._popup = new AppFolderPopup(this, side); this._popup = new AppFolderPopup(this, side);
this._parentView.addFolderPopup(this._popup); this._parentView.addFolderPopup(this._popup);
let constraint = new Clutter.AlignConstraint({ source: this._parentView.actor,
align_axis: Clutter.AlignAxis.X_AXIS,
factor: 0.5 });
this._popup.actor.add_constraint(constraint);
// Position the popup above or below the source icon // Position the popup above or below the source icon
if (side == St.Side.BOTTOM) { if (side == St.Side.BOTTOM) {
@ -600,7 +596,17 @@ const AppFolderPopup = new Lang.Class({
this._isOpen = false; this._isOpen = false;
this.actor = new St.Widget({ layout_manager: new Clutter.BinLayout(), this.actor = new St.Widget({ layout_manager: new Clutter.BinLayout(),
visible: false }); visible: false,
// We don't want to expand really, but look
// at the layout manager of our parent...
//
// DOUBLE HACK: if you set one, you automatically
// get the effect for the other direction too, so
// we need to set the y_align
x_expand: true,
y_expand: true,
x_align: Clutter.ActorAlign.CENTER,
y_align: Clutter.ActorAlign.START });
this._boxPointer = new BoxPointer.BoxPointer(this._arrowSide, this._boxPointer = new BoxPointer.BoxPointer(this._arrowSide,
{ style_class: 'app-folder-popup-bin', { style_class: 'app-folder-popup-bin',
x_fill: true, x_fill: true,