brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

network: don't assume NMActiveConnection has a device

Browse Source 
In practice this has been seen to fail:

    JS ERROR: TypeError: active.get_devices(...)[0] is undefined
    ensureActiveConnectionProps@resource:///org/gnome/shell/ui/status/network.js:73:22
    _getMainConnection@resource:///org/gnome/shell/ui/status/network.js:1791:13
    _syncMainConnection@resource:///org/gnome/shell/ui/status/network.js:1809:32

https://gitlab.gnome.org/GNOME/gnome-shell/issues/1406
This commit is contained in:
Will Thompson 2019-06-21 10:47:40 +01:00
parent ccf646f54a
commit 94ba52af0c
No known key found for this signature in database
GPG Key ID: 3422DC0D7AD482A7
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
js/ui/status/network.js
View File

@ -69,10 +69,13 @@ function ssidToLabel(ssid) {
function ensureActiveConnectionProps(active, client) { function ensureActiveConnectionProps(active, client) {
if (!active._primaryDevice) { if (!active._primaryDevice) {
// This list is guaranteed to have only one device in it. let devices = active.get_devices();
let device = active.get_devices()[0]._delegate; if (devices.length > 0) {
// This list is guaranteed to have at most one device in it.
let device = devices[0]._delegate;
active._primaryDevice = device; active._primaryDevice = device;
} }
}
} }
var NMConnectionItem = class { var NMConnectionItem = class {