brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

global: Filter out destroyed actors from get_window_actors()

Browse Source 
All current code assumes that the list of window actors corresponds to the
list of windows; however as the list returned by meta_get_window_actors()
now includes actors during the destroy animation, that assumption breaks.

Eventually we should make everyone move to a more appropriate API, but
for now make it work again by returning a filtered list of "good"
window actors.

https://bugzilla.gnome.org/show_bug.cgi?id=735927
This commit is contained in:
Florian Müllner 2014-09-10 22:41:40 +02:00
parent ec3f8d4b85
commit 93205eefb9
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/shell-global.c
View File

@ -735,14 +735,21 @@ shell_global_get_display (ShellGlobal *global)
* *
* Gets the list of #MetaWindowActor for the plugin's screen * Gets the list of #MetaWindowActor for the plugin's screen
* *
* Return value: (element-type Meta.WindowActor) (transfer none): the list of windows * Return value: (element-type Meta.WindowActor) (transfer container): the list of windows
*/ */
GList * GList *
shell_global_get_window_actors (ShellGlobal *global) shell_global_get_window_actors (ShellGlobal *global)
{ {
GList *filtered = NULL;
GList *l;
g_return_val_if_fail (SHELL_IS_GLOBAL (global), NULL); g_return_val_if_fail (SHELL_IS_GLOBAL (global), NULL);
return meta_get_window_actors (global->meta_screen); for (l = meta_get_window_actors (global->meta_screen); l; l = l->next)
if (!meta_window_actor_is_destroyed (l->data))
filtered = g_list_prepend (filtered, l->data);
return g_list_reverse (filtered);
} }
static void static void