From 90fae00aa6c0d13db995453dbd6b4bcf483f8f9c Mon Sep 17 00:00:00 2001 From: "Jasper St. Pierre" Date: Mon, 14 Jan 2013 17:51:36 -0500 Subject: [PATCH] screenshot: Immediately show the flash spot The "flash" effect looks awkward when it fades in and out. Real camera have an immediate flash of light, which then seems to fade out as our eyes readjust the rapid change in lighting. https://bugzilla.gnome.org/show_bug.cgi?id=691875 --- js/ui/screenshot.js | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/js/ui/screenshot.js b/js/ui/screenshot.js index 12cf18642..5537bf155 100644 --- a/js/ui/screenshot.js +++ b/js/ui/screenshot.js @@ -242,7 +242,7 @@ const SelectArea = new Lang.Class({ }); Signals.addSignalMethods(SelectArea.prototype); -const FLASHSPOT_ANIMATION_TIME = 0.25; // seconds +const FLASHSPOT_ANIMATION_OUT_TIME = 0.5; // seconds const Flashspot = new Lang.Class({ Name: 'Flashspot', @@ -258,21 +258,12 @@ const Flashspot = new Lang.Class({ }, fire: function() { - this.actor.opacity = 0; - Tweener.addTween(this.actor, - { opacity: 255, - time: FLASHSPOT_ANIMATION_TIME, - transition: 'linear', - onComplete: Lang.bind(this, this._onFireShowComplete) - }); this.actor.show(); - }, - - _onFireShowComplete: function() { + this.actor.opacity = 255; Tweener.addTween(this.actor, { opacity: 0, - time: FLASHSPOT_ANIMATION_TIME, - transition: 'linear', + time: FLASHSPOT_ANIMATION_OUT_TIME, + transition: 'easeOutQuad', onComplete: Lang.bind(this, function() { this.destroy(); })