brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

environment: Remove transition tracking

Browse Source 
The tracking was important in an earlier iteration, but as the helper
functions now remove overwritten transitions before setting up the
new ones, we can just as well connect to the ::stopped signal directly.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/668
This commit is contained in:
Florian Müllner
2019-08-07 02:28:40 +02:00
parent 8b368d010f
commit 9073debe60
1 changed files with 2 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
js/ui/environment.js
View File

@ -58,20 +58,6 @@ function _patchLayoutClass(layoutClass, styleProps) {
};
}
let _easingTransitions = new Map();
function _trackTransition(transition, callback) {
if (_easingTransitions.has(transition))
transition.disconnect(_easingTransitions.get(transition));
let id = transition.connect('stopped', (t, isFinished) => {
_easingTransitions.delete(transition);
callback(isFinished);
});
_easingTransitions.set(transition, id);
}
function _makeEaseCallback(params) {
let onComplete = params.onComplete;
delete params.onComplete;
@ -136,7 +122,7 @@ function _easeActor(actor, params) {
let transition = actor.get_transition(animatedProps[0]);
if (transition)
_trackTransition(transition, callback);
transition.connect('stopped', (t, finished) => callback(finished));
else
callback(true);
}
@ -180,7 +166,7 @@ function _easeActorProperty(actor, propName, target, params) {
transition.set_to(target);
if (callback)
_trackTransition(transition, callback);
transition.connect('stopped', (t, finished) => callback(finished));
}
function _loggingFunc(...args) {