brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

messageTray: Disconnect signals when resetting notification

Browse Source 
Just like we did for the parent class in commit b57832716a, we should
disconnect any notification signals when the notification is reset
to null to avoid warnings later.

https://gitlab.gnome.org/GNOME/gnome-shell/issues/942
This commit is contained in:
Florian Müllner 2019-01-29 15:30:40 +01:00 committed by Florian Müllner
parent 95a31b0c31
commit 8f732e4f45
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
js/ui/messageTray.js
View File

@ -497,9 +497,12 @@ class NotificationBanner extends Calendar.NotificationMessage {
}); });
} }
_onDestroy() { _disconnectNotificationSignals() {
super._onDestroy(); super._disconnectNotificationSignals();
this.notification.disconnect(this._activatedId);
if (this._activatedId)
this.notification.disconnect(this._activatedId);
this._activatedId = 0;
} }
_onUpdated(n, clear) { _onUpdated(n, clear) {