From 8e9398be7e4fc3ad7e5dc9b8d83d56fdcc3caa35 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Tue, 1 Aug 2023 19:13:10 +0300 Subject: [PATCH] popupMenu: Never add ornament padding to image items PopupImageMenuItem moves the ornament after the label, so we don't need the additional padding that accounts for visible ornaments for regular items. Spotted by Sebastian Keller. Part-of: --- js/ui/popupMenu.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/js/ui/popupMenu.js b/js/ui/popupMenu.js index 9033c9044..7b876ed24 100644 --- a/js/ui/popupMenu.js +++ b/js/ui/popupMenu.js @@ -474,6 +474,11 @@ class PopupImageMenuItem extends PopupBaseMenuItem { else this._icon.icon_name = icon; } + + _updateOrnamentStyle() { + // we move the ornament after the label, so we don't need + // additional padding regardless of ornament visibility + } }); var PopupMenuBase = class extends Signals.EventEmitter {