brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

popupMenu: Use less ambiguous symbols for radio options

Browse Source 
- new checked and unchecked dot ornament assets
- updated JS with a NO_DOT ornament state, replaced instances of NONE with this

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3027>
This commit is contained in:
Sam Hewitt
2023-11-23 11:16:18 -03:30
committed by Marge Bot
parent c4fcc82137
commit 8e1241c29b
11 changed files with 73 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
js/ui/status/keyboard.js
View File

@ -27,7 +27,7 @@ class LayoutMenuItem extends PopupMenu.PopupBaseMenuItem {
_init(displayName, shortName) {
super._init();
this.setOrnament(PopupMenu.Ornament.NONE);
this.setOrnament(PopupMenu.Ornament.NO_DOT);
this.label = new St.Label({
text: displayName,
@ -932,7 +932,7 @@ class InputSourceIndicator extends PanelMenu.Button {
let newSource = this._inputSourceManager.currentSource;
if (oldSource) {
this._menuItems[oldSource.index].setOrnament(PopupMenu.Ornament.NONE);
this._menuItems[oldSource.index].setOrnament(PopupMenu.Ornament.NO_DOT);
this._indicatorLabels[oldSource.index].hide();
}
@ -1011,7 +1011,7 @@ class InputSourceIndicator extends PanelMenu.Button {
radioGroup.push(item);
item.radioGroup = radioGroup;
item.setOrnament(prop.get_state() === IBus.PropState.CHECKED
? PopupMenu.Ornament.DOT : PopupMenu.Ornament.NONE);
? PopupMenu.Ornament.DOT : PopupMenu.Ornament.NO_DOT);
item.connect('activate', () => {
if (item.prop.get_state() === IBus.PropState.CHECKED)
return;
@ -1024,7 +1024,7 @@ class InputSourceIndicator extends PanelMenu.Button {
ibusManager.activateProperty(
item.prop.get_key(), IBus.PropState.CHECKED);
} else {
group[j].setOrnament(PopupMenu.Ornament.NONE);
group[j].setOrnament(PopupMenu.Ornament.NO_DOT);
group[j].prop.set_state(IBus.PropState.UNCHECKED);
ibusManager.activateProperty(
group[j].prop.get_key(), IBus.PropState.UNCHECKED);