brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

popupMenu: Use less ambiguous symbols for radio options

Browse Source 
- new checked and unchecked dot ornament assets
- updated JS with a NO_DOT ornament state, replaced instances of NONE with this

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3027>
This commit is contained in:
Sam Hewitt
2023-11-23 11:16:18 -03:30
committed by Marge Bot
parent c4fcc82137
commit 8e1241c29b
11 changed files with 73 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
js/ui/popupMenu.js
View File

@ -19,6 +19,7 @@ export const Ornament = {
DOT: 1,
CHECK: 2,
HIDDEN: 3,
NO_DOT: 4,
};
function isPopupMenuItemVisible(child) {
@ -256,8 +257,11 @@ export const PopupBaseMenuItem = GObject.registerClass({
this._ornament = ornament;
if (ornament === Ornament.DOT) {
this._ornamentIcon.icon_name = 'ornament-dot-symbolic';
this._ornamentIcon.icon_name = 'ornament-dot-checked-symbolic';
this.add_accessible_state(Atk.StateType.CHECKED);
} else if (ornament === Ornament.NO_DOT) {
this._ornamentIcon.icon_name = 'ornament-dot-unchecked-symbolic';
this.remove_accessible_state(Atk.StateType.CHECKED);
} else if (ornament === Ornament.CHECK) {
this._ornamentIcon.icon_name = 'ornament-check-symbolic';
this.add_accessible_state(Atk.StateType.CHECKED);
@ -271,7 +275,7 @@ export const PopupBaseMenuItem = GObject.registerClass({
}
_updateOrnamentStyle() {
if (this._ornament !== Ornament.HIDDEN)
if (this._ornament === Ornament.CHECK || this._ornament === Ornament.NONE)
this.add_style_class_name('popup-ornamented-menu-item');
else
this.remove_style_class_name('popup-ornamented-menu-item');