brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

frequentView: Use BaseAppView.addItem() and loadGrid()

Browse Source 
FrequentView is another view that is slightly not unified with how
BaseAppView expects subclasses to load app icons. Instead of using
BaseAppView.addItem() and then calling BaseAppview.loadGrid(), it
adds the app icons directly to the icon grid.

Make FrequentView add icons using BaseAppview.addItem(), and load
the icons using BaseAppView.loadGrid().

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/645
This commit is contained in:
Georges Basile Stavracas Neto 2019-06-29 13:15:20 -03:00
parent 4d23c12028
commit 8d9da10710
No known key found for this signature in database
GPG Key ID: 886C17EE170D1385
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
js/ui/appDisplay.js
View File

@ -706,6 +706,11 @@ var FrequentView = class FrequentView extends BaseAppView {
return this._usage.get_most_used().length >= MIN_FREQUENT_APPS_COUNT; return this._usage.get_most_used().length >= MIN_FREQUENT_APPS_COUNT;
} }
_compareItems() {
// The FrequentView does not need to be sorted alphabetically
return 0;
}
_loadApps() { _loadApps() {
let mostUsed = this._usage.get_most_used(); let mostUsed = this._usage.get_most_used();
let hasUsefulData = this.hasUsefulData(); let hasUsefulData = this.hasUsefulData();
@ -726,8 +731,10 @@ var FrequentView = class FrequentView extends BaseAppView {
continue; continue;
let appIcon = new AppIcon(mostUsed[i], let appIcon = new AppIcon(mostUsed[i],
{ isDraggable: favoritesWritable }); { isDraggable: favoritesWritable });
this._grid.addItem(appIcon, -1); this.addItem(appIcon);
} }
this.loadGrid();
} }
// Called before allocation to calculate dynamic spacing // Called before allocation to calculate dynamic spacing