From 8d6efde09151d6634990fda228bb1d6a94fb7be9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Wed, 17 May 2017 23:27:37 +0200 Subject: [PATCH] Revert "extensionSystem: handle reloading broken extensions" Both reloadExtensions() and enableExtensions() are already expected to catch extension errors. If they don't, this is the bug that should be fixed instead of catching unhandled exceptions in the caller. This reverts commit ff425d1db7082e2755d2a405af53861552acf2a1. https://bugzilla.gnome.org/show_bug.cgi?id=781728 --- js/ui/extensionSystem.js | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/js/ui/extensionSystem.js b/js/ui/extensionSystem.js index fc352b895..a4dc29eea 100644 --- a/js/ui/extensionSystem.js +++ b/js/ui/extensionSystem.js @@ -282,20 +282,12 @@ function _onVersionValidationChanged() { // temporarily disable them all enabledExtensions = []; for (let uuid in ExtensionUtils.extensions) - try { - reloadExtension(ExtensionUtils.extensions[uuid]); - } catch(e) { - logExtensionError(uuid, e); - } + reloadExtension(ExtensionUtils.extensions[uuid]); enabledExtensions = getEnabledExtensions(); if (Main.sessionMode.allowExtensions) { enabledExtensions.forEach(function(uuid) { - try { - enableExtension(uuid); - } catch(e) { - logExtensionError(uuid, e); - } + enableExtension(uuid); }); } }