From 8d139bbd95a5d62e0ba20b711a10a8b669cb9e9d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonas=20Dre=C3=9Fler?= Date: Wed, 22 Apr 2020 17:27:54 +0200 Subject: [PATCH] authPrompt: Grab key focus when making entry sensitive We currently let the entry of the autoPrompt grab the key focus inside setQuestion(), which is called from _onAskQuestion(), which is the callback of the "ask-question" signal. It seems that the "ask-question" signal isn't emitted again right after the password-check failed, but a few seconds after that. Since we get the "verification-failed" signal earlier than "ask-question" (right after we know the check failed) and we also get a hint whether the entry should be usable again with the canRetry argument, we can also grab key focus to in the same step. So do that by grabbing key focus when making the entry sensitive. Fixes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2655 --- js/gdm/authPrompt.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/js/gdm/authPrompt.js b/js/gdm/authPrompt.js index c26b1bcad..29170c555 100644 --- a/js/gdm/authPrompt.js +++ b/js/gdm/authPrompt.js @@ -424,7 +424,13 @@ var AuthPrompt = GObject.registerClass({ } updateSensitivity(sensitive) { + if (this._entry.reactive === sensitive) + return; + this._entry.reactive = sensitive; + + if (sensitive) + this._entry.grab_key_focus(); } vfunc_hide() {