brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

windowManager: Remove timeout on starting X11 services

Browse Source 
With Xwayland started on demand, mutter/gnome-shell will spawn Xwayland
and GNOME settings daemon Xsettings.

Currently, gnome-shell uses a timeout of 5 seconds before canceling the
launch and declare failure to start X11 services.

While 5 seconds may seem like a lot of time, when this is executed on a
virtual machine part of a QA tests under load, this causes random
failures.

There is no good value here, we could increase the timeout but it will
always remain racy. Instead, remove the timeout, systemd itself already
has a timeout mechanism (with a much longer wait time).

Thanks to Benjamin Berg <bberg@redhat.com> for finding the root cause
and suggesting the fix.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1888>
This commit is contained in:
Olivier Fourdan 2021-06-15 08:50:56 +02:00
parent 8d042459ee
commit 8be5d33611
1 changed files with 3 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
js/ui/windowManager.js
View File

@ -907,14 +907,7 @@ var WindowManager = class {
global.display.connect('init-xserver', (display, task) => { global.display.connect('init-xserver', (display, task) => {
IBusManager.getIBusManager().restartDaemon(['--xim']); IBusManager.getIBusManager().restartDaemon(['--xim']);
/* Timeout waiting for start job completion after 5 seconds */ this._startX11Services(task);
let cancellable = new Gio.Cancellable();
GLib.timeout_add_seconds(GLib.PRIORITY_DEFAULT, 5, () => {
cancellable.cancel();
return GLib.SOURCE_REMOVE;
});
this._startX11Services(task, cancellable);
return true; return true;
}); });
@ -972,11 +965,11 @@ var WindowManager = class {
}); });
} }
async _startX11Services(task, cancellable) { async _startX11Services(task) {
let status = true; let status = true;
try { try {
await Shell.util_start_systemd_unit( await Shell.util_start_systemd_unit(
'gnome-session-x11-services-ready.target', 'fail', cancellable); 'gnome-session-x11-services-ready.target', 'fail', null);
} catch (e) { } catch (e) {
// Ignore NOT_SUPPORTED error, which indicates we are not systemd // Ignore NOT_SUPPORTED error, which indicates we are not systemd
// managed and gnome-session will have taken care of everything // managed and gnome-session will have taken care of everything