brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

environment: Fix transition callback

Browse Source 
This is rather embarrassing - we currently confuse the transition with
the finished parameter, which means we always run the onComplete handler
no matter whether the transition was interrupted or actually completed.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/668
This commit is contained in:
Florian Müllner 2019-08-07 02:26:32 +02:00
parent 8b97a06961
commit 8b368d010f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
js/ui/environment.js
View File

@ -64,7 +64,7 @@ function _trackTransition(transition, callback) {
if (_easingTransitions.has(transition)) if (_easingTransitions.has(transition))
transition.disconnect(_easingTransitions.get(transition)); transition.disconnect(_easingTransitions.get(transition));
let id = transition.connect('stopped', isFinished => { let id = transition.connect('stopped', (t, isFinished) => {
_easingTransitions.delete(transition); _easingTransitions.delete(transition);
callback(isFinished); callback(isFinished);
}); });