brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

boxPointer: Rename show/hide to open/close

Browse Source 
Pretty much like dd4709bb2, BoxPointer's show() and hide()
functions will clash with Clutter.Actor's ones.

In addition to that, on a conceptual level, the current API
is not great, because calling boxPointer.hide() won't result
in boxPointer.actor.visible == false.

For these reasons, rename show() and hide() to open() and
close(). A compatibility layer will be added in a following
commit, warning about the usage of show() and hide().

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/153
This commit is contained in:
Georges Basile Stavracas Neto
2018-08-21 07:29:44 -03:00
parent 0c0d76f7d6
commit 8b215b2446
6 changed files with 12 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
js/ui/boxpointer.js
View File

@ -80,7 +80,7 @@ var BoxPointer = new Lang.Class({
}
},
show(animate, onComplete) {
open(animate, onComplete) {
let themeNode = this.actor.get_theme_node();
let rise = themeNode.get_length('-arrow-rise');
let animationTime = (animate & PopupAnimation.FULL) ? POPUP_ANIMATION_TIME : 0;
@ -121,7 +121,7 @@ var BoxPointer = new Lang.Class({
time: animationTime });
},
hide(animate, onComplete) {
close(animate, onComplete) {
if (!this.actor.visible)
return;