brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

st-adjustment: Mark all properties as EXPLICIT_NOTIFY

Browse Source 
All adjustment setter functions take good care of avoiding emission of
notify:: when it's not needed. The set_property() implementation already
calls into the setter functions, so mark the properties as EXPLICITY_NOTIFY
in order to optimize notify:: emission away through g_object_set (rather
common from JS code).

(cherry picked from commit b1b455ff1a)

Closes: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1270
This commit is contained in:
Carlos Garnacho 2018-06-28 20:22:40 +02:00 committed by Daniel van Vugt
parent 5703a25e2b
commit 8702d6647b
1 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/st/st-adjustment.c
View File

@ -205,7 +205,8 @@ st_adjustment_class_init (StAdjustmentClass *klass)
G_MAXDOUBLE, G_MAXDOUBLE,
0.0, 0.0,
ST_PARAM_READWRITE | ST_PARAM_READWRITE |
G_PARAM_CONSTRUCT)); G_PARAM_CONSTRUCT |
G_PARAM_EXPLICIT_NOTIFY));
g_object_class_install_property (object_class, g_object_class_install_property (object_class,
PROP_UPPER, PROP_UPPER,
g_param_spec_double ("upper", g_param_spec_double ("upper",
@ -215,7 +216,8 @@ st_adjustment_class_init (StAdjustmentClass *klass)
G_MAXDOUBLE, G_MAXDOUBLE,
0.0, 0.0,
ST_PARAM_READWRITE | ST_PARAM_READWRITE |
G_PARAM_CONSTRUCT)); G_PARAM_CONSTRUCT |
G_PARAM_EXPLICIT_NOTIFY));
g_object_class_install_property (object_class, g_object_class_install_property (object_class,
PROP_VALUE, PROP_VALUE,
g_param_spec_double ("value", g_param_spec_double ("value",
@ -225,7 +227,8 @@ st_adjustment_class_init (StAdjustmentClass *klass)
G_MAXDOUBLE, G_MAXDOUBLE,
0.0, 0.0,
ST_PARAM_READWRITE | ST_PARAM_READWRITE |
G_PARAM_CONSTRUCT)); G_PARAM_CONSTRUCT |
G_PARAM_EXPLICIT_NOTIFY));
g_object_class_install_property (object_class, g_object_class_install_property (object_class,
PROP_STEP_INC, PROP_STEP_INC,
g_param_spec_double ("step-increment", g_param_spec_double ("step-increment",
@ -235,7 +238,8 @@ st_adjustment_class_init (StAdjustmentClass *klass)
G_MAXDOUBLE, G_MAXDOUBLE,
0.0, 0.0,
ST_PARAM_READWRITE | ST_PARAM_READWRITE |
G_PARAM_CONSTRUCT)); G_PARAM_CONSTRUCT |
G_PARAM_EXPLICIT_NOTIFY));
g_object_class_install_property (object_class, g_object_class_install_property (object_class,
PROP_PAGE_INC, PROP_PAGE_INC,
g_param_spec_double ("page-increment", g_param_spec_double ("page-increment",
@ -245,7 +249,8 @@ st_adjustment_class_init (StAdjustmentClass *klass)
G_MAXDOUBLE, G_MAXDOUBLE,
0.0, 0.0,
ST_PARAM_READWRITE | ST_PARAM_READWRITE |
G_PARAM_CONSTRUCT)); G_PARAM_CONSTRUCT |
G_PARAM_EXPLICIT_NOTIFY));
g_object_class_install_property (object_class, g_object_class_install_property (object_class,
PROP_PAGE_SIZE, PROP_PAGE_SIZE,
g_param_spec_double ("page-size", g_param_spec_double ("page-size",
@ -255,7 +260,8 @@ st_adjustment_class_init (StAdjustmentClass *klass)
G_MAXDOUBLE, G_MAXDOUBLE,
0.0, 0.0,
ST_PARAM_READWRITE | ST_PARAM_READWRITE |
G_PARAM_CONSTRUCT)); G_PARAM_CONSTRUCT |
G_PARAM_EXPLICIT_NOTIFY));
/** /**
* StAdjustment::changed: * StAdjustment::changed:
* @self: the #StAdjustment * @self: the #StAdjustment