brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chrome: drop visibleInOverview

Browse Source 
Every place that called chrome.addActor was specifying
visibleInOverview:true, and no existing designs call for chrome that
disappears when you enter the overview, so just drop that as an
option.

https://bugzilla.gnome.org/show_bug.cgi?id=633620
This commit is contained in:
Dan Winship 2011-06-10 11:01:19 -04:00
parent bfec396ec2
commit 82a8ac1976
4 changed files with 12 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
js/ui/chrome.js
View File

@ -14,7 +14,6 @@ const Params = imports.misc.params;
// workspace content. // workspace content.
const defaultParams = { const defaultParams = {
visibleInOverview: false,
visibleInFullscreen: false, visibleInFullscreen: false,
affectsStruts: true, affectsStruts: true,
affectsInputRegion: true affectsInputRegion: true
@ -73,11 +72,8 @@ Chrome.prototype = {
// in its visibility will affect the input region, but NOT the // in its visibility will affect the input region, but NOT the
// struts. // struts.
// //
// If %visibleInOverview is %true in @params, @actor will remain // If %visibleInFullscreen is %true, the actor will be visible
// visible when the overview is brought up. Otherwise it will // even when a fullscreen window should be covering it.
// automatically be hidden. Likewise, if %visibleInFullscreen is
// %true, the actor will be visible even when a fullscreen window
// should be covering it.
// //
// If %affectsStruts or %affectsInputRegion is %false, the actor // If %affectsStruts or %affectsInputRegion is %false, the actor
// will not have the indicated effect. // will not have the indicated effect.
@ -96,7 +92,7 @@ Chrome.prototype = {
// //
// @params can have any of the same values as in addActor(), though // @params can have any of the same values as in addActor(), though
// some possibilities don't make sense (eg, trying to have a // some possibilities don't make sense (eg, trying to have a
// %visibleInOverview child of a non-%visibleInOverview parent). // %visibleInFullscreen child of a non-%visibleInFullscreen parent).
// By default, @actor has the same params as its chrome ancestor. // By default, @actor has the same params as its chrome ancestor.
trackActor: function(actor, params) { trackActor: function(actor, params) {
let ancestor = actor.get_parent(); let ancestor = actor.get_parent();
@ -189,10 +185,8 @@ Chrome.prototype = {
_updateVisibility: function() { _updateVisibility: function() {
for (let i = 0; i < this._trackedActors.length; i++) { for (let i = 0; i < this._trackedActors.length; i++) {
let actorData = this._trackedActors[i]; let actorData = this._trackedActors[i];
if (this._inOverview && !actorData.visibleInOverview) if (!this._inOverview && !actorData.visibleInFullscreen &&
this.actor.set_skip_paint(actorData.actor, true); this._findMonitorForActor(actorData.actor).inFullscreen)
else if (!this._inOverview && !actorData.visibleInFullscreen &&
this._findMonitorForActor(actorData.actor).inFullscreen)
this.actor.set_skip_paint(actorData.actor, true); this.actor.set_skip_paint(actorData.actor, true);
else else
this.actor.set_skip_paint(actorData.actor, false); this.actor.set_skip_paint(actorData.actor, false);

1
js/ui/messageTray.js
View File

@ -1252,7 +1252,6 @@ MessageTray.prototype = {
this._reNotifyAfterHideNotification = null; this._reNotifyAfterHideNotification = null;
Main.chrome.addActor(this.actor, { affectsStruts: false, Main.chrome.addActor(this.actor, { affectsStruts: false,
visibleInOverview: true,
visibleInFullscreen: true }); visibleInFullscreen: true });
Main.chrome.trackActor(this._notificationBin); Main.chrome.trackActor(this._notificationBin);
Main.chrome.trackActor(this._summaryBoxPointer.actor); Main.chrome.trackActor(this._summaryBoxPointer.actor);

14
js/ui/panel.js
View File

@ -708,7 +708,7 @@ HotCorner.prototype = {
} }
}); });
Main.chrome.addActor(this.actor, { visibleInOverview: true, affectsStruts: false }); Main.chrome.addActor(this.actor, { affectsStruts: false });
}, },
destroy: function() { destroy: function() {
@ -1004,13 +1004,11 @@ Panel.prototype = {
this.button.checked = false; this.button.checked = false;
})); }));
Main.chrome.addActor(this.actor, { visibleInOverview: true }); Main.chrome.addActor(this.actor);
Main.chrome.addActor(this._leftCorner.actor, { visibleInOverview: true, Main.chrome.addActor(this._leftCorner.actor, { affectsStruts: false,
affectsStruts: false, affectsInputRegion: false });
affectsInputRegion: false }); Main.chrome.addActor(this._rightCorner.actor, { affectsStruts: false,
Main.chrome.addActor(this._rightCorner.actor, { visibleInOverview: true, affectsInputRegion: false });
affectsStruts: false,
affectsInputRegion: false });
Main.ctrlAltTabManager.addGroup(this.actor, _("Top Bar"), 'start-here', Main.ctrlAltTabManager.addGroup(this.actor, _("Top Bar"), 'start-here',
{ sortGroup: CtrlAltTab.SortGroup.TOP }); { sortGroup: CtrlAltTab.SortGroup.TOP });

3
js/ui/panelMenu.js
View File

@ -26,8 +26,7 @@ Button.prototype = {
this.menu = new PopupMenu.PopupMenu(this.actor, menuAlignment, St.Side.TOP, 0); this.menu = new PopupMenu.PopupMenu(this.actor, menuAlignment, St.Side.TOP, 0);
this.menu.connect('open-state-changed', Lang.bind(this, this._onOpenStateChanged)); this.menu.connect('open-state-changed', Lang.bind(this, this._onOpenStateChanged));
this.menu.actor.connect('key-press-event', Lang.bind(this, this._onMenuKeyPress)); this.menu.actor.connect('key-press-event', Lang.bind(this, this._onMenuKeyPress));
Main.chrome.addActor(this.menu.actor, { visibleInOverview: true, Main.chrome.addActor(this.menu.actor, { affectsStruts: false });
affectsStruts: false });
this.menu.actor.hide(); this.menu.actor.hide();
}, },