From 80c16aa8f798206ed668c8b46dcc16261178d0bf Mon Sep 17 00:00:00 2001 From: Ron Yorsten Date: Mon, 5 Dec 2011 10:32:04 +0100 Subject: [PATCH] layout: Make ripple boxes initially invisible The three boxes for the ripple animation are visible when created. This means that the drag and drop code that searches for an actor to handle the drag can find the ripple boxes instead of the Activities button or hot corner. The latter can handle drag and drop while the ripple boxes can't. This is only a problem if drag and drop is attempted before the ripple animation has been played: the boxes are made invisible at the end of the animation. The fix is to just create the boxes invisible. --- js/ui/layout.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/js/ui/layout.js b/js/ui/layout.js index c99c94177..fb808ec52 100644 --- a/js/ui/layout.js +++ b/js/ui/layout.js @@ -433,9 +433,9 @@ const HotCorner = new Lang.Class({ Lang.bind(this, this._onCornerLeft)); // Cache the three ripples instead of dynamically creating and destroying them. - this._ripple1 = new St.BoxLayout({ style_class: 'ripple-box', opacity: 0 }); - this._ripple2 = new St.BoxLayout({ style_class: 'ripple-box', opacity: 0 }); - this._ripple3 = new St.BoxLayout({ style_class: 'ripple-box', opacity: 0 }); + this._ripple1 = new St.BoxLayout({ style_class: 'ripple-box', opacity: 0, visible: false }); + this._ripple2 = new St.BoxLayout({ style_class: 'ripple-box', opacity: 0, visible: false }); + this._ripple3 = new St.BoxLayout({ style_class: 'ripple-box', opacity: 0, visible: false }); Main.uiGroup.add_actor(this._ripple1); Main.uiGroup.add_actor(this._ripple2);