From 805b686576b1cd0576bdc96f64990de79f7c23bf Mon Sep 17 00:00:00 2001 From: Carlos Soriano Date: Sat, 26 Jul 2014 17:36:17 +0200 Subject: [PATCH] overviewControls: don't override explicit calls to slideIn Currently we are overriding the explicit calls to slideIn given that it's called also with the signal of showing overview. It was necessary because of the bug that previous patch fixed, so now we can just delete that. https://bugzilla.gnome.org/show_bug.cgi?id=732901 --- js/ui/overviewControls.js | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/js/ui/overviewControls.js b/js/ui/overviewControls.js index b396ff012..261c1034a 100644 --- a/js/ui/overviewControls.js +++ b/js/ui/overviewControls.js @@ -118,7 +118,6 @@ const SlidingControl = new Lang.Class({ style_class: 'overview-controls', clip_to_allocation: true }); - Main.overview.connect('showing', Lang.bind(this, this._onOverviewShowing)); Main.overview.connect('hiding', Lang.bind(this, this._onOverviewHiding)); Main.overview.connect('item-drag-begin', Lang.bind(this, this._onDragBegin)); @@ -177,14 +176,9 @@ const SlidingControl = new Lang.Class({ transition: 'easeOutQuad' }); }, - _onOverviewShowing: function() { - this._visible = true; - this.layout.slideX = this._getSlide(); - this.layout.translationX = this._getTranslation(); - this.slideIn(); - }, - _onOverviewHiding: function() { + // We need to explicitily slideOut since showing pages + // doesn't implies to slide out, instead, hiding the overview does. this.slideOut(); },