From 7d6c85be42e34e01d85d3e1cc644ec32e43522da Mon Sep 17 00:00:00 2001 From: "Jasper St. Pierre" Date: Tue, 2 Oct 2012 20:24:56 -0300 Subject: [PATCH] messageTray: Don't animate the desktop clone for a failed tray grab If we fail to grab for the message tray, we shouldn't be animating the desktop clone. This is a regression from commit fe124e6. https://bugzilla.gnome.org/show_bug.cgi?id=685342 --- js/ui/messageTray.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/js/ui/messageTray.js b/js/ui/messageTray.js index 9baaaeacb..8b27d3d0e 100644 --- a/js/ui/messageTray.js +++ b/js/ui/messageTray.js @@ -2028,7 +2028,7 @@ const MessageTray = new Lang.Class({ let trayShouldBeVisible = (this._summaryState == State.SHOWING || this._summaryState == State.SHOWN); if (!trayIsVisible && trayShouldBeVisible) - this._showTray(); + trayShouldBeVisible = this._showTray(); else if (trayIsVisible && !trayShouldBeVisible) this._hideTray(); @@ -2078,7 +2078,7 @@ const MessageTray = new Lang.Class({ modal: modal, onUngrab: Lang.bind(this, this._escapeTray) })) { this._traySummoned = false; - return; + return false; } this._tween(this.actor, '_trayState', State.SHOWN, @@ -2090,6 +2090,8 @@ const MessageTray = new Lang.Class({ if (this._overviewVisible) { this._lightbox.show(); } + + return true; }, _showDesktopClone: function() {