brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

loginDialog: pre-allocate prompt message height

Browse Source 
Right now things jump around if a message comes in.
This commit makes sure there's room for a message to start.
This commit is contained in:
Ray Strode 2013-06-19 12:56:23 -04:00
parent 2d98903c90
commit 7b440f3864
1 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
js/ui/auth/loginDialog.js
View File

@ -161,11 +161,10 @@ const LoginDialog = new Lang.Class({
{ expand: false, { expand: false,
x_fill: false }); x_fill: false });
this._promptMessage = new St.Label({ visible: false }); this._promptMessage = new St.Label({ opacity: 0 });
this._promptBox.add(this._promptMessage, { x_fill: true }); this._promptBox.add(this._promptMessage, { x_fill: true });
this._promptLoginHint = new St.Label({ style_class: 'login-dialog-prompt-login-hint-message' }); this._promptLoginHint = new St.Label({ style_class: 'login-dialog-prompt-login-hint-message' });
this._promptLoginHint.hide();
this._promptBox.add(this._promptLoginHint); this._promptBox.add(this._promptLoginHint);
this._sessionList = new SessionList.SessionList(); this._sessionList = new SessionList.SessionList();
@ -290,7 +289,7 @@ const LoginDialog = new Lang.Class({
this._userVerifier.clear(); this._userVerifier.clear();
this._updateSensitivity(true); this._updateSensitivity(true);
this._promptMessage.hide(); this._promptMessage.opacity = 0;
this._user = null; this._user = null;
this._verifyingUser = false; this._verifyingUser = false;
@ -342,20 +341,19 @@ const LoginDialog = new Lang.Class({
if (message) { if (message) {
this._promptMessage.text = message; this._promptMessage.text = message;
this._promptMessage.styleClass = styleClass; this._promptMessage.styleClass = styleClass;
this._promptMessage.show(); this._promptMessage.opacity = 255;
} else { } else {
this._promptMessage.hide(); this._promptMessage.opacity = 0;
} }
}, },
_showLoginHint: function(verifier, message) { _showLoginHint: function(verifier, message) {
this._promptLoginHint.set_text(message) this._promptLoginHint.set_text(message)
this._promptLoginHint.show();
this._promptLoginHint.opacity = 255; this._promptLoginHint.opacity = 255;
}, },
_hideLoginHint: function() { _hideLoginHint: function() {
this._promptLoginHint.hide(); this._promptLoginHint.opacity = 0;
this._promptLoginHint.set_text(''); this._promptLoginHint.set_text('');
}, },
@ -497,7 +495,7 @@ const LoginDialog = new Lang.Class({
this._setWorking(false); this._setWorking(false);
this._promptBox.hide(); this._promptBox.hide();
this._promptLoginHint.hide(); this._promptLoginHint.opacity = 0;
this._promptUser.set_child(null); this._promptUser.set_child(null);
@ -505,7 +503,7 @@ const LoginDialog = new Lang.Class({
this._promptEntry.set_text(''); this._promptEntry.set_text('');
this._sessionList.close(); this._sessionList.close();
this._promptLoginHint.hide(); this._promptLoginHint.opacity = 0;
this._buttonBox.destroy_all_children(); this._buttonBox.destroy_all_children();
this._signInButton = null; this._signInButton = null;