brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

windowManager: Keep dim effect in overview

Browse Source 
Removing the effect dates back to the time when we didn't show
attached dialogs in the overview. Since we do show attached
dialogs as such nowadays, it makes sense to keep the effect.

Close https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/6265

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3151>
This commit is contained in:
Florian Müllner 2024-01-29 21:12:44 +01:00
parent 8887301955
commit 7b4054564e
1 changed files with 0 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
js/ui/windowManager.js
View File

@ -512,8 +512,6 @@ export class WindowManager {
this._resizePending = new Set();
this._destroying = new Set();
this._dimmedWindows = [];
this._skippedActors = new Set();
this._allowedKeybindings = {};
@ -930,15 +928,6 @@ export class WindowManager {
IBusManager.getIBusManager().restartDaemon();
});
Main.overview.connect('showing', () => {
for (let i = 0; i < this._dimmedWindows.length; i++)
this._undimWindow(this._dimmedWindows[i]);
});
Main.overview.connect('hiding', () => {
for (let i = 0; i < this._dimmedWindows.length; i++)
this._dimWindow(this._dimmedWindows[i]);
});
this._windowMenuManager = new WindowMenu.WindowMenuManager();
if (Main.sessionMode.hasWorkspaces)
@ -1426,12 +1415,9 @@ export class WindowManager {
if (shouldDim && !window._dimmed) {
window._dimmed = true;
this._dimmedWindows.push(window);
this._dimWindow(window);
} else if (!shouldDim && window._dimmed) {
window._dimmed = false;
this._dimmedWindows =
this._dimmedWindows.filter(win => win !== window);
this._undimWindow(window);
}
}
@ -1560,10 +1546,6 @@ export class WindowManager {
_destroyWindow(shellwm, actor) {
let window = actor.meta_window;
window.disconnectObject(actor);
if (window._dimmed) {
this._dimmedWindows =
this._dimmedWindows.filter(win => win !== window);
}
if (window.is_attached_dialog())
this._checkDimming(window.get_transient_for());