brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[ShellApp] fix app/window sort order

Browse Source 
The window lists were not being resorted when user-time changed, and
the app list was mistakenly "penalizing" apps for having *any*
minimized windows, rather than for having *only* minimized windows.

https://bugzilla.gnome.org/show_bug.cgi?id=598389
This commit is contained in:
Dan Winship 2009-10-16 10:50:33 -04:00
parent 7c954898a2
commit 79a614240b
1 changed files with 19 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/shell-app.c
View File

@ -151,11 +151,11 @@ shell_app_has_visible_windows (ShellApp *app)
{ {
MetaWindow *window = iter->data; MetaWindow *window = iter->data;
if (!meta_window_showing_on_its_workspace (window)) if (meta_window_showing_on_its_workspace (window))
return FALSE; return TRUE;
} }
return TRUE; return FALSE;
} }
gboolean gboolean
@ -242,6 +242,21 @@ shell_app_on_unmanaged (MetaWindow *window,
_shell_app_remove_window (app, window); _shell_app_remove_window (app, window);
} }
static void
shell_app_on_user_time_changed (MetaWindow *window,
GParamSpec *pspec,
ShellApp *app)
{
/* Ideally we don't want to emit windows-changed if the sort order
* isn't actually changing. This check catches most of those.
*/
if (window != app->windows->data)
{
app->window_sort_stale = TRUE;
g_signal_emit (app, shell_app_signals[WINDOWS_CHANGED], 0);
}
}
static void static void
shell_app_on_ws_switch (MetaScreen *screen, shell_app_on_ws_switch (MetaScreen *screen,
int from, int from,
@ -263,6 +278,7 @@ _shell_app_add_window (ShellApp *app,
app->windows = g_slist_prepend (app->windows, g_object_ref (window)); app->windows = g_slist_prepend (app->windows, g_object_ref (window));
g_signal_connect (window, "unmanaged", G_CALLBACK(shell_app_on_unmanaged), app); g_signal_connect (window, "unmanaged", G_CALLBACK(shell_app_on_unmanaged), app);
g_signal_connect (window, "notify::user-time", G_CALLBACK(shell_app_on_user_time_changed), app);
app->window_sort_stale = TRUE; app->window_sort_stale = TRUE;
g_signal_emit (app, shell_app_signals[WINDOWS_CHANGED], 0); g_signal_emit (app, shell_app_signals[WINDOWS_CHANGED], 0);