From 76b03647b3c10f23f5ff9479d2772a727b2383eb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Wed, 9 Sep 2020 20:51:53 +0200 Subject: [PATCH] st/entry: Only handle primary/secondary icon clicks when reactive Just like the internal ClutterText, the icon actors are part of the entry. It therefore makes sense for the icons to not react to clicks when the entry itself is non-reactive; again, just like the text. That behavior is also consistent with icons in GTK entries. https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3138 --- src/st/st-entry.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/st/st-entry.c b/src/st/st-entry.c index fdf0168c9..043be6a7c 100644 --- a/src/st/st-entry.c +++ b/src/st/st-entry.c @@ -1312,6 +1312,9 @@ _st_entry_icon_clicked_cb (ClutterClickAction *action, { StEntryPrivate *priv = ST_ENTRY_PRIV (entry); + if (!clutter_actor_get_reactive (CLUTTER_ACTOR (entry))) + return; + if (actor == priv->primary_icon) g_signal_emit (entry, entry_signals[PRIMARY_ICON_CLICKED], 0); else