brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MessageTray: remove bad fast path in hideSummaryBoxPointer

Browse Source 
The onUngrab callback already checks if all notifications are destroyed and
hides immediately if so. Previous code instead would leave state handling
in an inconsistent state, by not removing the grab, not setting
summaryBoxPointerState to HIDDEN and not disconnecting various signals.

https://bugzilla.gnome.org/show_bug.cgi?id=684036
This commit is contained in:
Giovanni Campagna 2012-09-14 18:16:36 +02:00
parent e62c66b153
commit 7654f1ca3e
1 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
js/ui/messageTray.js
View File

@ -2436,14 +2436,6 @@ const MessageTray = new Lang.Class({
}, },
_hideSummaryBoxPointer: function() { _hideSummaryBoxPointer: function() {
// We should be sure to hide the box pointer if all notifications in it are destroyed while
// it is hiding, so that we don't show an animation of an empty blob being hidden.
if (this._summaryBoxPointerState == State.HIDING &&
this._summaryBoxPointerItem.notificationStack.get_n_children() == 0) {
this._summaryBoxPointer.actor.hide();
return;
}
this._grabHelper.ungrab({ actor: this._summaryBoxPointer.bin.child }); this._grabHelper.ungrab({ actor: this._summaryBoxPointer.bin.child });
}, },