From 74cd20116a456e3593e42899cf182c9a7b1be0c5 Mon Sep 17 00:00:00 2001 From: Emilio Pozuelo Monfort Date: Mon, 1 Jul 2013 18:37:59 +0200 Subject: [PATCH] boxpointer: fix left/right arrow side calculation Commit d6cace32 introduced a typo in the left/right arrow side calculation code that causes in most scenarios (where the monitor width is greater then the height) to not flip the box when it doesn't fit inside the monitor. https://bugzilla.gnome.org/show_bug.cgi?id=703403 --- js/ui/boxpointer.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/js/ui/boxpointer.js b/js/ui/boxpointer.js index 9f85e0254..2fd1a67c3 100644 --- a/js/ui/boxpointer.js +++ b/js/ui/boxpointer.js @@ -589,12 +589,12 @@ const BoxPointer = new Lang.Class({ return St.Side.TOP; break; case St.Side.LEFT: - if (sourceAllocation.y2 + boxWidth > monitor.x + monitor.width && + if (sourceAllocation.x2 + boxWidth > monitor.x + monitor.width && boxWidth < sourceAllocation.x1 - monitor.x) return St.Side.RIGHT; break; case St.Side.RIGHT: - if (sourceAllocation.y1 - boxWidth < monitor.x && + if (sourceAllocation.x1 - boxWidth < monitor.x && boxWidth < monitor.x + monitor.width - sourceAllocation.x2) return St.Side.LEFT; break;