brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "StThemeNodeDrawing: fill background behind translucent gradients"

Browse Source 
This reverts commit b4ec342d06.

The alpha > 0 checks should actually be alpha < 255 for the commit to
make sense as designed. The design isn't right either, though,
since we need to preserve the translucency in translucent gradients,
not block it with a solid color fill.

https://bugzilla.gnome.org/show_bug.cgi?id=640465
This commit is contained in:
Ray Strode 2011-02-15 17:00:22 -05:00
parent 1aba99336a
commit 740a946e72
1 changed files with 3 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/st/st-theme-node-drawing.c
View File

@ -452,8 +452,7 @@ st_theme_node_has_visible_outline (StThemeNode *node)
} }
static cairo_pattern_t * static cairo_pattern_t *
create_cairo_pattern_of_background_gradient (StThemeNode *node, create_cairo_pattern_of_background_gradient (StThemeNode *node)
gboolean *needs_background_fill)
{ {
cairo_pattern_t *pattern; cairo_pattern_t *pattern;
@ -483,12 +482,6 @@ create_cairo_pattern_of_background_gradient (StThemeNode *node,
node->background_gradient_end.green / 255., node->background_gradient_end.green / 255.,
node->background_gradient_end.blue / 255., node->background_gradient_end.blue / 255.,
node->background_gradient_end.alpha / 255.); node->background_gradient_end.alpha / 255.);
if (node->background_color.alpha > 0 ||
node->background_gradient_end.alpha > 0)
*needs_background_fill = TRUE;
else
*needs_background_fill = FALSE;
return pattern; return pattern;
} }
@ -794,8 +787,8 @@ st_theme_node_render_background_with_border (StThemeNode *node)
*/ */
if (node->background_gradient_type != ST_GRADIENT_NONE) if (node->background_gradient_type != ST_GRADIENT_NONE)
{ {
pattern = create_cairo_pattern_of_background_gradient (node, pattern = create_cairo_pattern_of_background_gradient (node);
&draw_solid_background); draw_solid_background = FALSE;
} }
else else
{ {