From 6fc5b0477ba1c77b6bcdd23e07254fbe97c92b83 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonas=20=C3=85dahl?= Date: Mon, 4 Sep 2017 17:47:35 +0800 Subject: [PATCH] theme-node: Fix font family formatting Unlike pango_font_description_from_string(), pango_font_description_set_family() requires a already properly formatted font family string. The proper format is a comma seperated list of font families, but we generated a "comma space" separated list. Passing a incorrectly formatted font family string to pango seems to cause wierd issues, where the wrong font is sometimes selected. For example, this fixes a font selection issue on zh_TW.UTF-8 locale for chinese characters, where previously the "Droid Sans" font was selected instead of "Source Han Sans TW" even though fontconfig had placed "Source Han Sans TW" before "Droid Sans". https://bugzilla.gnome.org/show_bug.cgi?id=786868 --- src/st/st-theme-node.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/st/st-theme-node.c b/src/st/st-theme-node.c index 877cf1da1..3739b93b4 100644 --- a/src/st/st-theme-node.c +++ b/src/st/st-theme-node.c @@ -2576,7 +2576,7 @@ font_family_from_terms (CRTerm *term, if (term->the_operator == NO_OP) g_string_append (family_string, " "); else - g_string_append (family_string, ", "); + g_string_append (family_string, ","); } else {