From 63a6c0d6f964c390048c3e55c3bb07c219206d9b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonas=20Dre=C3=9Fler?= Date: Wed, 22 Apr 2020 19:14:13 +0000 Subject: [PATCH] unlockDialog: Call AuthPrompt.addCharacter() directly The additional function UnlockDialog.addCharacter() is only used at one place, so we can simply remove it and call AuthPrompt.addCharacter() directly. The AuthPrompt is shown right before that anyway. https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1209 (cherry picked from commit fb1bb291eb5be666fcefd63ec68d33d45d0a6a1b) --- js/ui/unlockDialog.js | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/js/ui/unlockDialog.js b/js/ui/unlockDialog.js index 2170f12a7..29122ca51 100644 --- a/js/ui/unlockDialog.js +++ b/js/ui/unlockDialog.js @@ -605,7 +605,7 @@ var UnlockDialog = GObject.registerClass({ this._showPrompt(); if (GLib.unichar_isgraph(unichar)) - this.addCharacter(unichar); + this._authPrompt.addCharacter(unichar); return Clutter.EVENT_PROPAGATE; } @@ -835,11 +835,6 @@ var UnlockDialog = GObject.registerClass({ this._authPrompt.cancel(); } - addCharacter(unichar) { - this._showPrompt(); - this._authPrompt.addCharacter(unichar); - } - finish(onComplete) { this._ensureAuthPrompt(); this._authPrompt.finish(onComplete);