From 628e41890fe7f8a3493cb81d632293c8de4ac880 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Sun, 10 Dec 2023 23:21:38 +0100 Subject: [PATCH] extensions-app: Use details popover Showing all the extension info and possible actions in every row is fairly noisy, and doesn't match the usual list patterns. Streamline the UI by moving the actions and most of the info into a details popover, so the rows themselves get closer to the standard pattern. Closes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/7119 Part-of: --- subprojects/extensions-app/data/css/style.css | 22 +- .../scalable/actions/remove-symbolic.svg | 10 + .../scalable/actions/settings-symbolic.svg | 2 + .../scalable/actions/website-symbolic.svg | 2 + ...org.gnome.Extensions.data.gresource.xml.in | 3 + .../extensions-app/data/ui/extension-row.ui | 318 ++++++++++-------- subprojects/extensions-app/js/main.js | 23 +- 7 files changed, 226 insertions(+), 154 deletions(-) create mode 100644 subprojects/extensions-app/data/icons/scalable/actions/remove-symbolic.svg create mode 100644 subprojects/extensions-app/data/icons/scalable/actions/settings-symbolic.svg create mode 100644 subprojects/extensions-app/data/icons/scalable/actions/website-symbolic.svg diff --git a/subprojects/extensions-app/data/css/style.css b/subprojects/extensions-app/data/css/style.css index f9fafa717..8564ba501 100644 --- a/subprojects/extensions-app/data/css/style.css +++ b/subprojects/extensions-app/data/css/style.css @@ -1,18 +1,16 @@ -row.extension>box { - margin: 12px; +.details-popover contents { + padding: 12px; } -row.extension>box, -row.extension box.header { - border-spacing: 12px; -} - -row.extension box.actions, -row.extension box.actions>box { +.details-popover .information { border-spacing: 6px; } -row.extension box.information, -row.extension box.status { - border-spacing: 3px; +.details-popover .actions { + margin-top: 6px; + border-spacing: 12px; +} + +.details-popover .actions button { + padding: 12px; } diff --git a/subprojects/extensions-app/data/icons/scalable/actions/remove-symbolic.svg b/subprojects/extensions-app/data/icons/scalable/actions/remove-symbolic.svg new file mode 100644 index 000000000..b6f8bd1db --- /dev/null +++ b/subprojects/extensions-app/data/icons/scalable/actions/remove-symbolic.svg @@ -0,0 +1,10 @@ + + + + + + + + + + diff --git a/subprojects/extensions-app/data/icons/scalable/actions/settings-symbolic.svg b/subprojects/extensions-app/data/icons/scalable/actions/settings-symbolic.svg new file mode 100644 index 000000000..4ac785e2e --- /dev/null +++ b/subprojects/extensions-app/data/icons/scalable/actions/settings-symbolic.svg @@ -0,0 +1,2 @@ + + diff --git a/subprojects/extensions-app/data/icons/scalable/actions/website-symbolic.svg b/subprojects/extensions-app/data/icons/scalable/actions/website-symbolic.svg new file mode 100644 index 000000000..1a5b3c9e7 --- /dev/null +++ b/subprojects/extensions-app/data/icons/scalable/actions/website-symbolic.svg @@ -0,0 +1,2 @@ + + diff --git a/subprojects/extensions-app/data/org.gnome.Extensions.data.gresource.xml.in b/subprojects/extensions-app/data/org.gnome.Extensions.data.gresource.xml.in index 47aaf8cd8..fe9cbad08 100644 --- a/subprojects/extensions-app/data/org.gnome.Extensions.data.gresource.xml.in +++ b/subprojects/extensions-app/data/org.gnome.Extensions.data.gresource.xml.in @@ -4,6 +4,9 @@ css/style.css icons/scalable/actions/info-symbolic.svg + icons/scalable/actions/remove-symbolic.svg + icons/scalable/actions/settings-symbolic.svg + icons/scalable/actions/website-symbolic.svg ui/help-overlay.ui diff --git a/subprojects/extensions-app/data/ui/extension-row.ui b/subprojects/extensions-app/data/ui/extension-row.ui index 38c374ab1..5208a9aa6 100644 --- a/subprojects/extensions-app/data/ui/extension-row.ui +++ b/subprojects/extensions-app/data/ui/extension-row.ui @@ -1,173 +1,227 @@ -