brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

breakManager: Fix a potential null object dereference

Browse Source 
There’s no `else` branch above, so it’s possible for
`this._notification` to be `null` at the bottom of the function
(especially if the user has explicitly closed the previous
notification), so handle that.

Signed-off-by: Philip Withnall <pwithnall@gnome.org>

Helps: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/8280
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3687>
This commit is contained in:
Philip Withnall 2025-04-02 12:05:43 +01:00 committed by Bruce Leidl
parent 35ead0422c
commit 6131beead6
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
js/misc/breakManager.js
View File

@ -1278,8 +1278,11 @@ class BreakNotificationSource extends GObject.Object {
this._scheduleUpdateState(updateTimeoutSeconds);
}
this._notification.urgency = this._urgencyForBreakType(this._manager.currentBreakType);
this._source.addNotification(this._notification);
if (this._notification) {
this._notification.urgency = this._urgencyForBreakType(this._manager.currentBreakType);
this._source.addNotification(this._notification);
}
break;
}