brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

message-tray: Don't update message count after destruction

Browse Source 
When trying to update the message count after a summary icon has
been destroyed, the label to display the count is no longer valid
and trying to set its text results in some Clutter warnings.
This commit is contained in:
Florian Müllner
2011-07-13 01:18:58 +02:00
parent b4f5e4206d
commit 5f6ac33d59
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
js/ui/messageTray.js
View File

@ -885,6 +885,11 @@ Source.prototype = {
this.actor.connect('get-preferred-width', Lang.bind(this, this._getPreferredWidth));
this.actor.connect('get-preferred-height', Lang.bind(this, this._getPreferredHeight));
this.actor.connect('allocate', Lang.bind(this, this._allocate));
this.actor.connect('destroy', Lang.bind(this,
function() {
this._actorDestroyed = true;
}));
this._actorDestroyed = false;
this._counterLabel = new St.Label();
this._counterBin = new St.Bin({ style_class: 'summary-source-counter',
@ -949,6 +954,9 @@ Source.prototype = {
},
_updateCount: function() {
if (this._actorDestroyed)
return;
let count = this.notifications.length;
this._setCount(count, count > 1);
},