From 5be67eb1907afd81c60b89145f53be19f416ba79 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Thu, 10 Jun 2021 01:55:31 +0200 Subject: [PATCH] lookingGlass: Only pop modal after the transition Right now we pop the modal immediately when closing, so the key-release event of the Escape key ends up in the focus window which may consume it for leaving fullscreen mode or similar. We can avoid that in many cases by keeping the modal grab until the end of the transition, as the key-release event will then likely occur while the grab is still in place (provided animations are enabled). Part-of: --- js/ui/lookingGlass.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/js/ui/lookingGlass.js b/js/ui/lookingGlass.js index a9f0512db..61d17b7d0 100644 --- a/js/ui/lookingGlass.js +++ b/js/ui/lookingGlass.js @@ -1368,8 +1368,6 @@ class LookingGlass extends St.BoxLayout { this.setBorderPaintTarget(null); - Main.popModal(this._entry); - let settings = St.Settings.get(); let duration = Math.min(LG_ANIMATION_TIME / settings.slow_down_factor, LG_ANIMATION_TIME); @@ -1377,7 +1375,10 @@ class LookingGlass extends St.BoxLayout { y: this._hiddenY, duration, mode: Clutter.AnimationMode.EASE_OUT_QUAD, - onComplete: () => this.hide(), + onComplete: () => { + Main.popModal(this._entry); + this.hide(); + }, }); }