brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

portalHelper: Use default_size instead of set_size_request for size

Browse Source 
GtkWidget.set_size_request() enforces a minimum size, while
GtkWidget.set_default_size() simply sets the default size.

The docs of set_size_request() say "In most cases,
gtk_window_set_default_size() is a better choice for toplevel windows", and
in our case it doesn't seem necessary to prohibit the window from having a
smaller size, so switch to using the default_width and default_height
properties.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3307>
This commit is contained in:
Jonas Dreßler 2024-05-09 10:03:23 +02:00
parent cbe7c4a677
commit 5aa89fa9e6
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
js/portalHelper/main.js
View File

@ -113,6 +113,8 @@ class PortalWindow extends Gtk.ApplicationWindow {
super._init({ super._init({
application, application,
title: _('Hotspot Login'), title: _('Hotspot Login'),
default_width: 600,
default_height: 450,
}); });
const headerbar = new Gtk.HeaderBar(); const headerbar = new Gtk.HeaderBar();
@ -153,7 +155,6 @@ class PortalWindow extends Gtk.ApplicationWindow {
this._syncUri(); this._syncUri();
this.set_child(this._webView); this.set_child(this._webView);
this.set_size_request(600, 450);
this.maximize(); this.maximize();
this.present_with_time(timestamp); this.present_with_time(timestamp);