From 56194ae5966abcdb26f70b74bb6d67217ed390e5 Mon Sep 17 00:00:00 2001 From: Ryan Lortie Date: Sun, 16 Nov 2014 15:50:14 -0800 Subject: [PATCH] network: properly remove connections from list Due to a typo we were always removing the first (index 0) connection from the global list of connections instead of the correct one. This resulted in some connections remaining in the shell's connection list long after they were removed. In particular, this resulted in multiple copies of a bluetooth connection appearing after suspend/resume (when the device was readded and the cached connection list was rescanned). https://bugzilla.gnome.org/show_bug.cgi?id=740227 (cherry picked from commit 3d4408dce810f3b6995ed2acf28b61bed48c1dac) --- js/ui/status/network.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/ui/status/network.js b/js/ui/status/network.js index 0ff203729..2134f71dd 100644 --- a/js/ui/status/network.js +++ b/js/ui/status/network.js @@ -1591,7 +1591,7 @@ const NMApplet = new Lang.Class({ _connectionRemoved: function(connection) { let pos = this._connections.indexOf(connection); if (pos != -1) - this._connections.splice(connection, 1); + this._connections.splice(pos, 1); let section = connection._section;