network: properly remove connections from list

Due to a typo we were always removing the first (index 0) connection
from the global list of connections instead of the correct one.

This resulted in some connections remaining in the shell's connection
list long after they were removed.  In particular, this resulted in
multiple copies of a bluetooth connection appearing after suspend/resume
(when the device was readded and the cached connection list was
rescanned).

https://bugzilla.gnome.org/show_bug.cgi?id=740227
(cherry picked from commit 3d4408dce810f3b6995ed2acf28b61bed48c1dac)
This commit is contained in:
Ryan Lortie 2014-11-16 15:50:14 -08:00 committed by Dan Williams
parent 630ad8fd05
commit 56194ae596

View File

@ -1591,7 +1591,7 @@ const NMApplet = new Lang.Class({
_connectionRemoved: function(connection) {
let pos = this._connections.indexOf(connection);
if (pos != -1)
this._connections.splice(connection, 1);
this._connections.splice(pos, 1);
let section = connection._section;