brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

switcherPopup: Swap Math.max and Math.min in _scrollToLeft

Browse Source 
Limit the minimum and maximum value to scroll to inside the box to 0 and
the upper limit, for some reason this was done right in _scrollToRight,
but not in _scrollToLeft.

This fixes the behavior of scrolling to the left: Before, scrolling one
item to the left moved the view to the first element of the list (this
can make the selected element invisible in large lists). Instead, scroll
one item to the left, just like scrolling to the right works.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/167
This commit is contained in:
Jonas Dreßler 2018-04-25 23:56:29 +02:00 committed by Florian Müllner
parent 172d21cf50
commit 548c41d164
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
js/ui/switcherPopup.js
View File

@ -480,9 +480,9 @@ var SwitcherList = GObject.registerClass({
let item = this._items[index]; let item = this._items[index];
if (item.allocation.x1 < value) if (item.allocation.x1 < value)
value = Math.min(0, item.allocation.x1); value = Math.max(0, item.allocation.x1);
else if (item.allocation.x2 > value + pageSize) else if (item.allocation.x2 > value + pageSize)
value = Math.max(upper, item.allocation.x2 - pageSize); value = Math.min(upper, item.allocation.x2 - pageSize);
this._scrollableRight = true; this._scrollableRight = true;
adjustment.ease(value, { adjustment.ease(value, {